Fix usage of onload = t.step_timeout in WPT tests #33034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 2, 2022
t.step_timeout directly invokes setTimeout, so this pattern doesn't actually wait for onload. The pattern, as used elsewhere, should be something like: onload = () => t.step_timeout One app-history test in particular was causing issues as it became dependent timer task ordering. Bug: 1220223 Change-Id: I2a8c74e485833a3bc15cc53320c791ecb80452af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3499359 Auto-Submit: Scott Haseley <shaseley@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#976889}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3499359
branch
from
c28290e
to
f92be05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t.step_timeout directly invokes setTimeout, so this pattern doesn't
actually wait for onload. The pattern, as used elsewhere, should be
something like:
onload = () => t.step_timeout
One app-history test in particular was causing issues as it became
dependent timer task ordering.
Bug: 1220223
Change-Id: I2a8c74e485833a3bc15cc53320c791ecb80452af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3499359
Auto-Submit: Scott Haseley <shaseley@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976889}